Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Come up with solution to prevent redeploying too often #24

Open
hellais opened this issue Mar 15, 2024 · 0 comments · May be fixed by #59
Open

Come up with solution to prevent redeploying too often #24

hellais opened this issue Mar 15, 2024 · 0 comments · May be fixed by #59
Assignees
Labels
enhancement improving existing code or new feature funder/otffoss2023-2024 priority/low

Comments

@hellais
Copy link
Member

hellais commented Mar 15, 2024

Problem:

At the moment whenever something lands in master this triggers a rebuild and deployment of every configured service, including those which are not affected by any changes to the code.

For example if I make changes only to ooniauth, oonirun is also redeployed too. This should not really have any real impact and is not a big problem at the moment since we don't have too many services, however in the future this is problematic for 2 reasons:

  1. A change to an unrelated service might trigger the deployment of a broken unrelated service
  2. Even if 1. is mitigate, we are still building a new package and redeploying it for no reason (if our builds were reproducible it would be the exactly same package) costing us CPU cycles.

Possible solutions:

@hellais hellais assigned hellais and DecFox and unassigned hellais Mar 15, 2024
@hellais hellais added priority/low enhancement improving existing code or new feature labels Mar 15, 2024
@DecFox DecFox linked a pull request Jun 21, 2024 that will close this issue
@hellais hellais removed their assignment Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement improving existing code or new feature funder/otffoss2023-2024 priority/low
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants