Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle case confirmed: true & blocking: false #248

Open
hellais opened this issue Aug 13, 2019 · 1 comment
Open

Handle case confirmed: true & blocking: false #248

hellais opened this issue Aug 13, 2019 · 1 comment
Assignees
@majakomel
Labels
backend needed bug Something isn't working correctly discuss Needs discussion before proceeding enhancement New feature request or improvement to existing functionality priority/low Nice to have

Comments

@hellais
Copy link
Member

hellais commented Aug 13, 2019

As mentioned in: #239 (comment) there can be some cases in which the measurement is confirmed (because we see a blockpage), but the blocking test_key is set to false, maybe because the control request failed.

In these cases, currently, we don't show the reason for blocking under the website as we do for the others.

We should consider if we want to handle this case in a special way, perhaps by enriching the pipeline-side heuristics to also determine the blocking method.

An sample measurement for this is: https://explorer-beta.ooni.io/measurement/20190703T163625Z_AS8708_UwLHVRiAoYGcScetNQ2uobFjyawbW11oqw4ZMIN8qJEZEF41pX?input=http://www.slotland.com.

cc @FedericoCeratto
@hellais hellais added bug Something isn't working correctly enhancement New feature request or improvement to existing functionality discuss Needs discussion before proceeding labels Aug 13, 2019
@hellais hellais added this to the Future releases milestone Aug 13, 2019
@hellais hellais mentioned this issue Aug 13, 2019
Merged
@hellais hellais added the priority/medium Normal priority issue label Jan 16, 2020
@hellais
Copy link
Member Author

hellais commented May 12, 2020

This is blocked by ooni/backend#326

@sarathms sarathms removed this from the Sprint 14 - Ponyo milestone Jun 5, 2020
@hellais hellais removed this from the Sprint 41 - Trumpetfish milestone Jun 17, 2021
@bassosimone bassosimone assigned majakomel and unassigned sarathms Apr 6, 2023
@hellais hellais added this to Roadmap Jan 7, 2025
@hellais hellais removed this from Roadmap Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@majakomel majakomel

Labels
backend needed bug Something isn't working correctly discuss Needs discussion before proceeding enhancement New feature request or improvement to existing functionality priority/low Nice to have
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@bassosimone @hellais @sarathms @majakomel @jbonisteel