Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lack of P_ACK within the change cipher spec packet #34

Open
ainghazal opened this issue Oct 21, 2022 · 0 comments
Open

lack of P_ACK within the change cipher spec packet #34

ainghazal opened this issue Oct 21, 2022 · 0 comments

Comments

@ainghazal
Copy link
Collaborator

ainghazal commented Oct 21, 2022

Originally reported by 7asecurity during their security audit:

During TLS/VPN negotiation, OpenVPN clients send a Change Cipher Spec P_CONTROL_V1 packet, which contains an embedded P_ACK_V1 packet. OpenVPN in that way uses the ability to combine both P_CONTROL and P_ACK payloads1 inside a single packet. However, minivpn sends two packets (see figure)

missing_p_ack

I think this is due to the naive implementation of the ack mechanism in the current state, that doesn't allow to send ACKs for several packet ids within a single control packet. I think this can be better handled after landing #32

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant