Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

netx: merge with github.com/ooni/probe-engine #357

Closed
bassosimone opened this issue Feb 21, 2020 · 1 comment
Closed

netx: merge with github.com/ooni/probe-engine #357

bassosimone opened this issue Feb 21, 2020 · 1 comment
Assignees
@bassosimone
Labels
enhancement New feature or request ooni/netx Issues related to github.com/ooni/netx ooni/probe-engine Issues related to github.com/ooni/probe-engine priority/medium Medium priority research prototype Research required

Comments

@bassosimone
Copy link
Contributor

Same argument as for #356. Specifically, jafar is the other consumer of netx. Maybe by moving everything inside here we can also consolidate the integration tests that we run, and we can run integration testing of netx directly? Also: when investigsting #355, I noticed that there is opportunity for radically simplifying netx in a bunch of places, without necessarily gutting its external API. This can be more easily done inside the same repository when we can check for API breakages immediately. (For the records, this move has been suggested to me by @FedericoCeratto some time ago, but I didn't feel like changing what was working until that become an issue preventing me/us from moving faster, which I currently think is becoming the case.)
@bassosimone bassosimone added enhancement New feature or request research prototype Research required priority/medium Medium priority effort/L Large effort ooni/netx Issues related to github.com/ooni/netx ooni/probe-engine Issues related to github.com/ooni/probe-engine labels Feb 21, 2020
@bassosimone bassosimone self-assigned this Feb 21, 2020
@bassosimone bassosimone added the interrupt Task not planned during planning label Feb 21, 2020
@bassosimone bassosimone added effort/XS Extra small effort and removed interrupt Task not planned during planning effort/L Large effort labels Feb 24, 2020
@bassosimone bassosimone removed this from the Sprint 8 - Flounder milestone Mar 2, 2020
@bassosimone bassosimone removed the effort/XS Extra small effort label Mar 3, 2020
@bassosimone
Copy link
Contributor Author

This has been done in #380. No time estimate because we've done it as part of #302.

@bassosimone bassosimone changed the title netx: merge with github.com/ooni/probe-engine? netx: merge with github.com/ooni/probe-engine Mar 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bassosimone bassosimone

Labels
enhancement New feature or request ooni/netx Issues related to github.com/ooni/netx ooni/probe-engine Issues related to github.com/ooni/probe-engine priority/medium Medium priority research prototype Research required
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bassosimone