Make setup.py more wheel friendly #22
Labels
bug
Something isn't working
Comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
@shirishag75 commented on Sat Aug 13 2016
As per https://lists.torproject.org/pipermail/ooni-dev/2016-August/000457.html
I have all the dependencies installed -
Then ran as given in the mailing list instructions -
Once that was done ran -
And finally ran -
As can be seen getting tracebacks. Look forward to clarity.
@hellais commented on Sat Aug 13 2016
What python version are you running? It seems like you may be running python3, that is currently not supported by ooniprobe.
Can you run from inside of the virtualenv:
python --version?@shirishag75 commented on Sun Aug 14 2016
running python 2.7.12 -
From outside the virtual env .
I actually tried it out once more and I got a bit more further -
[$] source ~/venv-ooniprobe-agent-alpha/bin/activateSo the only failures seem to be -
and finally
The above probably gives some more insight.
@shirishag75 commented on Sat Aug 13 2016
Just to make sure ( I'm no python user/geek) . I am running zsh hence the weird CLI interface -
@hellais commented on Tue Sep 13 2016
@shirishag75 sorry for getting back to you so late on this.
Could you perhaps try updating to the latest release candidate and see if the error still presents itself.
I have attempted in a couple of different setups to try to reproduce your error, but without success so far.
Can you also include the version of pip you are using (pip --version)?
You can try the new release candidate with the instructions found here: https://github.com/TheTorProject/ooni-probe/releases/tag/v2.0.0-rc.2
@shirishag75 commented on Tue Sep 13 2016
I am going to try it in sometime, will share as to whatever I get. As far as info. about pip is concerned, here are the details -
@shirishag75 commented on Tue Sep 13 2016
Still got the same issue - see the whole thing, tried from beginning, dunno if I should have cleaned up something or not -
┌─[shirish@debian] - [~] - [10198]
└─[$] virtualenv ~/venv-ooniprobe-agent-alpha/
Running virtualenv with interpreter /usr/bin/python2
New python executable in /home/shirish/venv-ooniprobe-agent-alpha/bin/python2
Not overwriting existing python script /home/shirish/venv-ooniprobe-agent-alpha/bin/python (you must use /home/shirish/venv-ooniprobe-agent-alpha/bin/python2)
Installing setuptools, pkg_resources, pip, wheel...done.
Maybe I did a mistake here ? Is there a way to clean the before python script ?
and then finally -
Hopefully, this can be resolved soonish.
@hellais commented on Tue Sep 13 2016
Can you share the version of pip inside of the virtualenv as well. For some reason it's trying to install it as a wheel and that is leading to it failing for a not found
PYTHONPATH.You can get that by doing:
Or just run
pip --versionafter you have activated the virtualenv.A temporary workaround to resolve your issue could be to do:
@hellais commented on Tue Sep 13 2016
Ok so I have figured out a way to reproduce this issue. pip will attempt to build a wheel for the package if you have the
wheelpackage installed.It seems like setting the PYTHONPATH doesn't overcome this issue.
I will look more into how we can make our package more wheel friendly, in the meantime if you install wheel you should be able to install it.
You can uninstall wheel with:
@hellais commented on Wed Sep 14 2016
Ok so I have come to the bottom of this.
Actually the installation is not broken, but ooniprobe will still be installed, however it does print out a sort of scary message, but that is only related to the build of the wheel and it will still manage to run.
You can confirm that is the case if you just fire up ooniprobe-agent with:
Now I think we should fix that scary message and even better we should fix wheel builds entirely, however this is currently a bit tricky due to the nature of how our setup.py works.
Until PEP-0426 there is no clean way of having post install hooks. We currently don't really need many post install hooks anymore expect for the ones we are using to manage the update and migration to the new update system for lepidopter based installs. For that reason we can't switch to an entirely supported wheel based setup.
I think as a temporary workaround to fix showing that scary message we could override the
bdist_wheelaction with some action that has an blankrun()method that just prints out some message saying that wheels are not supported. It's not great, but at least it doesn't show that message, that may trick users (and even me) into believing that ooniprobe is not installed and working.@shirishag75 commented on Wed Sep 14 2016
It's the same -
I have one question though, if I do -
pip uninstall wheelIt would just take python-wheel out of the virtualenv and not out of the system as I have -
As far as ooniprobe-agent is concerned, you are right, it does do the right thing. Now just have to configure ooniprobe to use tor.
@hellais commented on Wed Sep 14 2016
@shirishag75 can you confirm that ooniprobe is working as expected though?
If that is the case I will move the resolution of this user experience related issue to future releases.
Thanks a lot!
@shirishag75 commented on Wed Sep 14 2016
@hellais It was working as in I got the startup page on my browser. I have yet to tune it to tor which I'll probably try tomorrow . I haven't started running ooniprobe as I need to fix so that it takes tor and not firefox to show how ooniprobe runs.
The text was updated successfully, but these errors were encountered: