Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli/ci: iox_test.go:108: not the error we expected <nil> #1749

Closed
bassosimone opened this issue Aug 20, 2021 · 1 comment
Closed

cli/ci: iox_test.go:108: not the error we expected <nil> #1749

bassosimone opened this issue Aug 20, 2021 · 1 comment
Assignees
Labels
bug Something isn't working priority/low

Comments

@bassosimone
Copy link
Contributor

Describe the bug

The CI fails intermittently like this:

--- FAIL: TestCopyContextWithCancelledContext (0.00s)
Error:     iox_test.go:108: not the error we expected <nil>
FAIL
coverage: 100.0% of statements

See https://github.com/ooni/probe-cli/pull/445/checks?check_run_id=3381591044

To Reproduce
Run the CI multiple times per day, you should eventually see the failure.

Expected behavior
The test is not failing.

Screenshots
N/A

System information (please complete the following information):
GitHub Actions.

Additional context
I suppose the test works because of some race condition that does not always happen. If there is a timeout inside the test, then we should most likely increase it, so that the test works more often.

@bassosimone
Copy link
Contributor Author

It turns out I've already fixed this issue in ooni/probe-cli#484.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working priority/low
Projects
None yet
Development

No branches or pull requests

1 participant