Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix potential max runtime bug #1940

Closed
agrabeli opened this issue Dec 21, 2021 · 1 comment
Closed

Fix potential max runtime bug #1940

agrabeli opened this issue Dec 21, 2021 · 1 comment
Assignees
Labels
bug Something isn't working partner training 2021

Comments

@agrabeli
Copy link
Member

During the OONI Partner Training, a participant mentioned that although the app says that the max runtime is set to 90 seconds, it actually took 120 seconds to run. This may be a bug worth looking into to.

@hellais
Copy link
Member

hellais commented Jan 19, 2022

This is because the max runtime works by stopping scheduling any new tests once the timeout has been reached. That means that any still pending website test will need to run until the end and is the reason why it's never going to be exactly 90 seconds.

@hellais hellais closed this as completed Jan 19, 2022
@bassosimone bassosimone assigned hellais and unassigned bassosimone Jan 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working partner training 2021
Projects
None yet
Development

No branches or pull requests

3 participants