Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove toast Toast.WillBeAvailable #980

Closed
hellais opened this issue Jan 21, 2020 · 2 comments · Fixed by ooni/probe-android#289 or ooni/probe-ios#336
Closed

Remove toast Toast.WillBeAvailable #980

hellais opened this issue Jan 21, 2020 · 2 comments · Fixed by ooni/probe-android#289 or ooni/probe-ios#336
Assignees
@lorenzoPrimi
Labels
bug Something isn't working ooni/probe-mobile issues related to OONI Probe mobile priority/low ux
Milestone
Sprint 6 - Dumbo ...

Comments

@hellais
Copy link
Member

hellais commented Jan 21, 2020

Since the fastpath now ticks faster, we could/should remove the Toast.WillBeAvailable
@hellais hellais added bug Something isn't working ooni/probe-mobile issues related to OONI Probe mobile ux labels Jan 21, 2020
@lorenzoPrimi lorenzoPrimi added this to the Sprint 6 - Dumbo Octopus milestone Jan 22, 2020
@lorenzoPrimi lorenzoPrimi self-assigned this Feb 3, 2020
@lorenzoPrimi
Copy link

Do we also remove the string from transifex?

This was referenced Feb 5, 2020
Merged
Merged
@hellais
Copy link
Member Author

hellais commented Feb 5, 2020

Yes we should drop it from the translatable strings too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lorenzoPrimi lorenzoPrimi

Labels
bug Something isn't working ooni/probe-mobile issues related to OONI Probe mobile priority/low ux
Projects
None yet
Milestone
Sprint 6 - Dumbo Octopus
Development

Successfully merging a pull request may close this issue.

Remove Toast.WillBeAvailable ooni/probe-android
Remove Toast.WillBeAvailable ooni/probe-ios
2 participants
@hellais @lorenzoPrimi