Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send emails when commits are ingested #10

Closed
philc opened this issue Sep 1, 2011 · 9 comments
Closed

Send emails when commits are ingested #10

philc opened this issue Sep 1, 2011 · 9 comments

Comments

@philc
Copy link
Contributor

philc commented Sep 1, 2011

When pulling in new commits, we should send emails when a commit is ingested. Matching these commits to saved searches will be expensive, and so should be a separate background job, not part of the commit importer.

@philc
Copy link
Contributor Author

philc commented Sep 2, 2011

I'll be working on some substantial changes to how email jobs are queued this weekend, which would affect the design of this process. Consult with me before beginning on this.

@philc
Copy link
Contributor Author

philc commented Sep 5, 2011

I'll take this.

@ghost ghost assigned philc Sep 5, 2011
@philc
Copy link
Contributor Author

philc commented Sep 28, 2011

I'm going to port our jobs to Redis. At that point I'll add in support for emails upon commit ingestion.

@cespare
Copy link
Contributor

cespare commented Sep 28, 2011

Did you mean "resque"? I guess that runs on Redis.

@philc
Copy link
Contributor Author

philc commented Sep 28, 2011

Yep, meant Resque.

@philc
Copy link
Contributor Author

philc commented Oct 4, 2011

This is complete as of d5da83a.

@philc philc closed this as completed Oct 4, 2011
@mstyer
Copy link

mstyer commented Oct 5, 2011

This doesn't seem to work, maybe because the "email me on new commits" box isn't visible anywhere?

@cespare
Copy link
Contributor

cespare commented Oct 5, 2011

This is not deployed yet (it's going out tonight).

@philc
Copy link
Contributor Author

philc commented Oct 5, 2011

@mstyer, you can see the version and timestamp of the latest deploy here: http://barkeep.sv2/statusz

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants