Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Special-case empty files #71

Closed
cespare opened this issue Sep 27, 2011 · 2 comments
Closed

Special-case empty files #71

cespare opened this issue Sep 27, 2011 · 2 comments
Labels
feature request
Milestone
0.3.0 Release -- ...

Comments

@cespare
Copy link
Contributor

cespare commented Sep 27, 2011

We need to special case empty files in the diff view. We should be able to handle this in the same way as other special files (e.g. binaries) -- the infrastructure is there so that if we tag it as special and give it a message like "This file is empty", it will be displayed properly in the view.
@bkad bkad closed this as completed in c7e825d Sep 30, 2011
@bkad bkad reopened this Oct 1, 2011
@bkad
Copy link
Contributor

bkad commented Oct 1, 2011

c7e825d introduces a huge diff bug, the unified diff format is different for commit.show vs commit.diffs

@bkad
Copy link
Contributor

bkad commented Oct 6, 2011

fixed in fcbc4c4

@bkad bkad closed this as completed Oct 6, 2011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature request
Projects
None yet
Milestone
0.3.0 Release -- Internal Ooyala release
Development

No branches or pull requests
2 participants
@cespare @bkad