Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(providers): Introduce Providers Crate for Traits #589

Closed
refcell opened this issue Sep 30, 2024 · 1 comment
Closed

feat(providers): Introduce Providers Crate for Traits #589

refcell opened this issue Sep 30, 2024 · 1 comment
Labels
A-derive Area: kona-derive crate A-workspace Area: Top level workspace modifications

Comments

@refcell
Copy link
Collaborator

refcell commented Sep 30, 2024

Overview

#569 refactors "online" providers (alloy-backed std providers) out of kona-derive into a new kona-alloy-providers crate since providers are trait abstracted throughout the derivation pipeline. This drastically reduces the amount of feature-flag optional dependencies in kona-derive and isolates the generic pipeline implementation a bit better.

The next step in making traits extensible is to pull trait definitions out of kona-derive and into a new kona-providers crate that can be imported by both kona-derive and `kona-alloy-providers. Effectively, we can represent the dependency graph as follows.

graph TD;
    kona_derive-->kona_providers;
    kona_alloy_providers-->kona_providers;
    kona_alloy_providers-->kona_derive;
Loading

kona-providers should mirror how Alloy set up signer crates.

@refcell refcell added A-workspace Area: Top level workspace modifications A-derive Area: kona-derive crate labels Sep 30, 2024
@refcell
Copy link
Collaborator Author

refcell commented Oct 2, 2024

Fixed in #596

@refcell refcell closed this as completed Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-derive Area: kona-derive crate A-workspace Area: Top level workspace modifications
Projects
None yet
Development

No branches or pull requests

1 participant