Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate cannon support #889

Closed
samlaf opened this issue Jan 8, 2025 · 4 comments
Closed

Deprecate cannon support #889

samlaf opened this issue Jan 8, 2025 · 4 comments

Comments

@samlaf
Copy link
Contributor

samlaf commented Jan 8, 2025

Asked what was the state of cannon support on discord, and was told it was no longer supported:
Image

Feel like this should be better documented in the README. Perhaps the cannon build code should be removed (last commit is 2 years old)? Also maybe describe what's the state of cannon-rs and future plans regarding asterisc vs cannon-rs.

Is the point that the cannon code in the monorepo has a bunch of golang related elf changes (in the patcher) which doesn't work with rust code, hence why cannon-rs was started?

@clabby
Copy link
Collaborator

clabby commented Jan 10, 2025

Cannon support is in a bit of a weird spot. We do not have any plans to use it in production, but testing that kona can compile to the target is nice to ensure we can be compatible.

I'll think about this a bit.

p.s., we use a custom target. Rust does only have a supported built-in target for r6, but we specify an r1 target.

@samlaf
Copy link
Contributor Author

samlaf commented Jan 10, 2025

@clabby oh interesting pretty sure I saw a link to mips r2 somewhere, maybe in op-program or cannon documentation itself?

@tynes
Copy link
Contributor

tynes commented Jan 13, 2025

It would be really nice to be able to compile kona down to mips64 to remove asterisc from the hot path of getting kona to prod, but its still a lot of work validating that its production ready

@clabby clabby closed this as not planned Won't fix, can't repro, duplicate, stale Jan 17, 2025
@clabby
Copy link
Collaborator

clabby commented Jan 17, 2025

@clabby oh interesting pretty sure I saw a link to mips r2 somewhere, maybe in op-program or cannon documentation itself?

Yeah cannon is an impl of a mips{32/64}r2 processor. We run on a stricter target, but r2 processors should be backwards compatible w/ r1 programs.

Glad to revisit this in the future if we decide we never want to use cannon, closing as not planned for now :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants