Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dry run not honored #238

Closed
jichenjc opened this issue Jun 7, 2022 · 1 comment · Fixed by #253
Closed

dry run not honored #238

jichenjc opened this issue Jun 7, 2022 · 1 comment · Fixed by #253

Comments

@jichenjc
Copy link
Contributor

jichenjc commented Jun 7, 2022 

root@jitest19:~# ./clusteradm delete clusterset c2 --dry-run=true --context kind-hub
./clusteradm is running in dry-run mode
Clusterset c2 is deleted
root@jitest19:~# ./clusteradm get clustersets --context kind-hub
NAME      BOUND NAMESPACES   STATUS
c1        n1                 1 ManagedClusters selected
default                      No ManagedCluster selected
@IlonaShishov IlonaShishov mentioned this issue Aug 1, 2022
Merged
@IlonaShishov
Copy link
Contributor

Added a fix to the create cmd as well in which the dry-run flag was also not honored

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add dry run for create clusterset IlonaShishov/clusteradm
2 participants
@jichenjc @IlonaShishov