Enable status reporting for CatalogSource in OperatorPolicy #195
Conversation
zyjjay
force-pushed
the
ACM-9285
branch
3 times, most recently
from
fb72348
to
c5215ec
Compare
There was a problem hiding this comment.
I think an additional test scenario for a situation where the catalogsource is present, but not healthy, would cover the functionality I think this is still missing. To trigger that, I think you could patch the catalogsource's image. You might need to delete the existing catalogsource pod, I'm not sure how exactly it handles when that is updated, or how quickly the new status will be reflected.
|
The first test run had a failure on an unrelated test. I'm re-running the test. |
zyjjay
force-pushed
the
ACM-9285
branch
2 times, most recently
from
aac5d37
to
5c86cfe
Compare
Following the schema of implementing multiple `handle` functions, the CatalogSource status reporting logic utilizes the same `updateStatus` function to facilitate the `conditions` and `relatedObject` field updates on the related operator policy. The controller directly checks if the CatalogSource object exists on the cluster to propagate relevant health information up to the operator policy. The specific field that is checked in the catalog source is `.status.connectionState.lastObservedState`. Any value other than `READY` is considered as failing. ref: https://issues.redhat.com/browse/ACM-9285 Signed-off-by: Jason Zhang <jaszhang@redhat.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JustinKuli, zyjjay The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit 8f18c31
into
open-cluster-management-io:main
Following the schema of implementing multiple
handlefunctions, the CatalogSource status reporting logic utilizes the sameupdateStatusfunction to facilitate theconditionsandrelatedObjectfield updates on the related OperatorPolicy. The controller reads the conditions field on the watched Subscription to determine the health of the CatalogSource. In the event a Subscription is not created due to either aninformOperatorPolicy or an error, the controller directly checks if the CatalogSource object exists on the cluster to propagate relevant health information up to the OperatorPolicy.ref: https://issues.redhat.com/browse/ACM-9285