Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply auditing to entity Pedido and Renglon Pedido #465

Open
wants to merge 36 commits into
base: master
Choose a base branch
from

Conversation

k31kur0n0
Copy link
Member

No description provided.

@k31kur0n0 k31kur0n0 self-assigned this Apr 27, 2023
@k31kur0n0 k31kur0n0 linked an issue May 12, 2023 that may be closed by this pull request
pom.xml Outdated Show resolved Hide resolved
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 2, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

59.9% 59.9% Coverage
0.0% 0.0% Duplication

@open-commercial open-commercial deleted a comment from sonarqubecloud bot Jul 3, 2023
@belluccifranco
Copy link
Member

  • En el JSON de respuesta: al atributo usuario agregar un espacio en blanco antes del primer parentesis para separar bien el nombre del username
  • Al dar de alta un Pedido con 3 renglones y pedir sus renglones con el endpoint /pedidos/{id}/renglones/cambios solo retorna 1 de ellos
    image
  • En la respuesta del endpoint de renglones, eliminar un nivel de anidamiento, de tal manera que quede igual al endpoint de cambios de Pedido

@belluccifranco belluccifranco self-requested a review July 10, 2023 18:43
Copy link
Member

@belluccifranco belluccifranco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ver comentarios

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 6 Code Smells

83.0% 83.0% Coverage
0.0% 0.0% Duplication

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 6 Code Smells

83.0% 83.0% Coverage
0.0% 0.0% Duplication

Copy link

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

6 New issues
0 Security Hotspots
83.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Apply auditing to entity Pedido and Renglon Pedido
2 participants