Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Additional fields are under-reported: Check against schema, not just regex #73

Open
robredpath opened this issue Sep 23, 2020 · 1 comment
Open

Additional fields are under-reported: Check against schema, not just regex #73

robredpath opened this issue Sep 23, 2020 · 1 comment
Labels
additional fields bug Something isn't working

Comments

@robredpath
Copy link
Contributor

In OpenDataServices/cove#679 we identified an issue with fields containing an _ not being detected as additional fields.

Functionally, this is identical to OpenDataServices/cove#402

We now correctly report additional fields that contain an _ as long as the part that follows the _ doesn't conform to the format of a BCP 47 language tag. However, that's quite a wide range! @jpmckinney 's comment at OpenDataServices/cove#679 (comment) gives a clear example.

We should make the check smarter, such that if the first part before the _ isn't a field in the standard, we assume that it's an additional field and report on it.
@jpmckinney jpmckinney transferred this issue from open-contracting/cove-ocds Oct 15, 2020
@jpmckinney
Copy link
Member

jpmckinney commented Oct 15, 2020 •
edited
Loading

Requires a change to get_additional_fields_info (or sub-functions) in lib-cove.

@jpmckinney jpmckinney added the upstream Requires a change in a dependency label Oct 15, 2020
@jpmckinney jpmckinney changed the title Additional Fields: Detect when a field is a field from the schema with a language suffix and don't report it as an additional field Additional fields: Detect when a field is a field from the schema with a language suffix and don't report it as an additional field Jul 7, 2023
@jpmckinney jpmckinney mentioned this issue Nov 29, 2023
Closed
@jpmckinney jpmckinney added bug Something isn't working and removed upstream Requires a change in a dependency labels Oct 24, 2024
@jpmckinney jpmckinney changed the title Additional fields: Detect when a field is a field from the schema with a language suffix and don't report it as an additional field Additional fields are under-reported: Check against schema, not just regex Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
additional fields bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jpmckinney @robredpath