Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom end date before start date still returns a result! #77

Closed
sabahfromlondon opened this issue Jun 17, 2021 · 3 comments
Closed

Custom end date before start date still returns a result! #77

sabahfromlondon opened this issue Jun 17, 2021 · 3 comments
Assignees
@t-mrazek

Comments

@sabahfromlondon
Copy link

If I select the start date: 22 Jun 2020
And end date 21 Jun 2019

The registry returned results, where it should have thrown an error. See screenshot.

The fields should really be named "Start date" and "End date" as well.

Screenshot 2021-06-17 164547
@hrubyjan hrubyjan self-assigned this Jun 20, 2021
@hrubyjan
Copy link

Disable selection of nonsensical values and rename fields

@hrubyjan hrubyjan assigned t-mrazek and unassigned hrubyjan Jun 28, 2021
@t-mrazek
Copy link
Contributor

Fixed, the date fields are restricted by the selection of a date in the opposite field. The reset button added for the possibility of a value removing.

@sabahfromlondon
Copy link
Author

Yes look good to me now. I think it would also be helpful if the user is not allowed to select a date in the future. Is this possible?

@hrubyjan hrubyjan mentioned this issue Aug 27, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@t-mrazek t-mrazek

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@sabahfromlondon @hrubyjan @t-mrazek