Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update create server process to not add port knocking if Docker to be added later #427

Closed
jpmckinney opened this issue May 12, 2023 · 2 comments · Fixed by #418
Closed
Labels
docker documentation Improvements or additions to documentation

Comments

@jpmckinney
Copy link
Member

Right now we run onboarding and core first, which runs the firewall script. The firewall script checks for command -v docker, which will fail. It will then proceed to implement port knocking. https://ocdsdeploy.readthedocs.io/en/latest/deploy/create_server.html#apply-core-changes

We can either:

  • Check for either command -v docker or a non-empty DOCKER variable (e.g. add DOCKER to the firewall-settings.local template). That way, we can add a step to the documentation to set DOCKER, if appropriate.
  • Document how to reverse the firewall script. I did this by flushing iptables, adding port 22, deploying, and restarting the server. If that's it, we can document the steps more explicitly.
@jpmckinney
Copy link
Member Author

From email discussion: we can instead document how to reset the firewall at the appropriate time.

@jpmckinney jpmckinney added documentation Improvements or additions to documentation docker labels May 17, 2023
@jpmckinney jpmckinney added this to the Medium priority milestone May 26, 2023
@ghost ghost mentioned this issue Jun 7, 2023
12 tasks
@jpmckinney
Copy link
Member Author

Fixed by #418.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docker documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant