eForms SDK 1.12.0

[jpmckinney]

https://github.com/OP-TED/eForms-SDK/releases/tag/1.12.0

1.11 was #204

I haven't had a chance to review, but my typical process is to start a branch, run the "Upgrade SDK version" steps, and document changes here, like in #204 and earlier.

[odscjen]

Relevant

Business terms removed:

• BT-747-Lot Selection Criteria Type (only use of selection-criterion codelist)
• BT-748-Lot Selection Criteria Used (only use of usage codelist)
• BT-749-Lot Selection Criteria Name

New Business terms added

• BT-681-Lot Foreign Subsidies Regulation (uses fsr codelist)
• BT-682-Tender Foreign Subsidies Measures (uses foreign-subsidy-measure-conclusion codelist)
• BT-806-Procedure Exclusion Grounds Source (uses exclusion-grounds-source codelist)
• BT-809-Lot Selection Criteria (uses selection-criterion codelist)
• BT-821-Lot Selection Criteria Source (uses selection-criteria-source codelist)

Maybe relevant

Codelist values now listed rather than just naming the codelist:

• BT-01-notice (James) This is a codelist name change, with additional constraints

type 'id' now type 'id-ref' with list of 'idSchemes'

• BT-13714-Tender
• BT-1501(c)-Contract

No longer mandatory

• BT-09(b)-Procedure - for T01 T02
• BT-539-LotsGroup
• BT-543-LotsGroup

Conditional mandatory

• BT-512-Organization-Company
• BT-512-Organization-Touchpoint

Now mandatory

• BT-67(a)-Procedure
• BT-750-Lot

Codelist name change

• (James) eforms-legal-basis now legal-basis, referenced by BT-01-notice
• eforms-buyer-legal-type now buyer-legal-type, referenced by BT-11-Procedure-Buyer
• eforms-contract-nature now contract-nature, referenced by BT-23-Lot, BT-23-Part, BT-23-Procedure,BT-531-Lot, BT-531-Part, BT-531-Procedure
• eforms-language now language, referenced by BT-708-Lot, BT-708-Part, BT-737-Lot, BT-737-Part, BT-97-Lot

Change in xpathAbsolute

• BT-18-Lot
• BT-67(a)-Procedure
• BT-67(b)-Procedure
• BT-71-Lot
• BT-71-Part
• BT-745-Lot
• BT-771-Lot
• BT-772-Lot

Not relevant

New 'businessEntityID' added to all business terms

New 'referencedBusinessEntityIds' field

• BT-13713-LotResult
• BT-13714-Tender
• BT-13716-notice
• BT-1375-Procedure
• BT-1501(c)-Contract
• BT-1501(p)-Contract
• BT-3202-Contract
• BT-330-Procedure
• BT-556-NoticeResult
• OPT-300-Contract-Signatory
• OPT-300-Procedure-Buyer
• OPT-300-Procedure-SProvider
• OPT-300-Tenderer
• OPT-301-Lot/Part-AddInfo
• OPT-301-Lot/Part-DocProvider
• OPT-301-Lot/Part-EmployLegis
• OPT-301-Lot/Part-EnvironLegis
• OPT-301-Lot/Part-FiscalLegis
• OPT-301-Lot/Part-Mediator
• OPT-301-Lot/Part-ReviewInfo
• OPT-301-Lot/Part-ReviewOrg
• OPT-301-Lot/Part-TenderEval
• OPT-301-Lot/Part-TenderReceipt
• OPT-301-LotResult-Financing
• OPT-301-LotResult-PAying
• OPT-301-Tenderer-MainCont
• OPT-301-Tenderer-SubCont
• OPT-302-Organization
• OPT-310-Tender
• OPT-315-LotResult
• OPT-320-LotResult

[odscjen]

I'll review the changes for relevance and add the new guidance etc later this week

[jpmckinney]

I updated the instructions with a step to update drop (to ignore any irrelevant new properties like businessEntityId and referencedBusinessEntityIds), and I re-did the commit, to make the diff smaller. Please git pull. If you get merge conflicts, you can either (1) abandon the pull, git reset to a known good commit, then pull or (2) delete your local repository and start over (this assumes you have no local branches).

I also did this step:

Fields removed from source/fields.json remain in output/mapping/eforms/guidance.yaml with only eForms guidance, eForms example, OCDS example and sdk fields. Remove such fields manually.

The diff is a manageable size now: 045a51b

[odscjen]

edit - moved this comment to new issue #219

[odscjen]

Review results

Codelist name changes - no updates needed

Business terms removed - BT-747 and BT-749 are both referenced in mappings that affect the same SelectionCriteria objects. These references will need to be removed and likely replaced with references to BT-806, BT-809, BT-821 (still to create mappings for these new fields)

type 'id' now type 'id-ref' with list of 'idSchemes' - no changes needed, just placing constraints on the id code pattern for the publisher when they're creating their eForm but OCDS doesn't enforce similar constraints on the id fields being mapped to

mandatory changes - no changes needed to OCDS mapping

xpath changes

• BT-18-lot - no changes needed
• BT-67(a)-Procedure - update eforms example
• BT-67(b)-Procedure - update eforms example
• BT-71-Lot - no changes needed
• BT-71-Part - no changes needed
• BT-745-Lot - no changes needed
• BT-771-Lot - no changes needed
• BT-772-Lot - no changes needed

I'll apply the listed changes as part of a PR to update the mappings once they've been agreed

[odscjen]

moved this comment to new issue #220

[odscjen]

sorry I didn't think they were all going to be so big and I should have started new issues for them. I've done so for the final new field #218 and moved the others into their own issues