Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Environment variable for spiders needing proxy #1085

Closed
jpmckinney opened this issue Apr 27, 2024 · 1 comment
Closed

Environment variable for spiders needing proxy #1085

jpmckinney opened this issue Apr 27, 2024 · 1 comment
Labels
framework-spiders Relating to common spider functionality
Milestone

Comments

@jpmckinney
Copy link
Member

jpmckinney commented Apr 27, 2024

I hardcoded Montreal as using a proxy. Since the need for a proxy depends on the server, we can instead implement the list of spiders needing a proxy as an environment variable, and configure the custom settings on the base spider.

Would need to look into how/when Scrapy reads the custom_settings class attribute, as we’ll want subclasses to be able to add to it.

@jpmckinney jpmckinney added the framework-spiders Relating to common spider functionality label Apr 27, 2024
@jpmckinney jpmckinney added this to the Priority milestone Oct 8, 2024
@jpmckinney
Copy link
Member Author

Paraguay needs a proxy:

2024-09-26 12:05:02,592 WARNING [data_registry.process_manager:101] Irrecoverable error during task #9649(process) (Paraguay: Dirección Nacional de Contrataciones Públicas (DNCP) (63)): Collection is empty

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
framework-spiders Relating to common spider functionality
Projects
None yet
Development

No branches or pull requests

1 participant