Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider replacing some setup_* notebooks with kingfisher-colab functions #62

Open
yolile opened this issue Feb 23, 2024 · 3 comments
Open
Assignees

Comments

@yolile
Copy link
Member

yolile commented Feb 23, 2024

setup_charts, setup_usability and setup_download_data_from_registry only contain functions, so we could consider moving all these functions into a library, similar to https://github.com/open-contracting/kingfisher-colab. I thought about moving them there, but I guess that one is too kingfisher-specific.

@jpmckinney
Copy link
Member

Might as well put them there. We don’t need multiple internal libraries for Google Colab.

@yolile
Copy link
Member Author

yolile commented Feb 27, 2024

Sounds good, I will move them there when I'm done with the MVP notebooks. Having them as a library will reduce the number of components we have and also the need to update the dependent notebooks every time we change something in a function only.

@yolile yolile self-assigned this Feb 27, 2024
@jpmckinney
Copy link
Member

Btw I made some small changes, so maybe pull if you are working on changes.

@jpmckinney jpmckinney changed the title Consider replacing some setup_* notebooks with a library Consider replacing some setup_* notebooks with kingfisher-colab functions Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants