Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Value fields: remove "total" #1207

Closed
JachymHercher opened this issue Feb 7, 2021 · 4 comments · Fixed by #1401
Closed

Value fields: remove "total" #1207

JachymHercher opened this issue Feb 7, 2021 · 4 comments · Fixed by #1401
Assignees
Labels
quick Ready for PR Semantics Relating to field and code descriptions
Milestone

Comments

@JachymHercher
Copy link
Contributor

JachymHercher commented Feb 7, 2021

Value fields in OCDS often use the term "total". I am not sure what it means and I think it might be misleading, e.g. because a "total" value field might be tax-less (see #817) or represent just a single award, contract a lot from a contracting process that contains more of them.

I would suggest replacing:

  • "total estimated value" with "estimated value" in tender.value
  • "total value" with "value" in award.value and contract.value.
@JachymHercher JachymHercher added quick Semantics Relating to field and code descriptions labels Feb 7, 2021
@JachymHercher JachymHercher added this to the 1.2.0 milestone Feb 7, 2021
@JachymHercher JachymHercher changed the title Value fields: "procurement", "total" and "upper" Value fields: remove "total" Feb 7, 2021
@ColinMaudry
Copy link
Member

I think "estimated" is important, otherwise data publishers may think the field only supports a fixed value.

@jpmckinney
Copy link
Member

@JachymHercher I support the changes to award.value and contract.value.

For tender.value, did you mean to delete "total" instead of "estimated"?

@JachymHercher
Copy link
Contributor Author

Yes, corrected, sorry.

@JachymHercher
Copy link
Contributor Author

(To avoid unnecessary conflicts, I will create the PR for this issue once #1208 is merged (it moves around some value fields).)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
quick Ready for PR Semantics Relating to field and code descriptions
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants