-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Primer feedback #1370
Comments
I had a peek at this as well and have some readability feedback which shouldn't be too heavy in most parts: https://standard.open-contracting.org/latest/en/primer/what/
The final point reads a bit off, as Data Standards in the abstract tends to be pluralised. In the subsequent bullet points, we also pluralise it. I would change the sentence to read "There are three concepts behind the OCDS: Open Contracting, Open Data, and Data Standards.".
Citations needed. While we're not in academia, if we're making claims such as these we should be backing them up or it reflects poorly on us. Recommend either blog-style referencing with inline hyperlinks to papers, or IEEE style with numbered citations and a list of sources at the bottom of the page. To be clear; I don't think that all knowledge needs to be enshrined in published papers -- but if we're claiming that academic research says X, then we need to cite it. https://standard.open-contracting.org/latest/en/primer/how/
This might be one for the longer-term, but it'd be really great if this linked off to a summary or some writing about our initial research. I wasn't around when this was performed; did we communicate our findings anywhere? Again, it doesn't need to be peer-reviewed venues but if we had a section on the OCP website which states what our original research found, it'd be great to show our working and to link to it here. https://standard.open-contracting.org/latest/en/primer/releases_and_records/
I'm wary that we've just come from the previous page where we've said that OCDS can be published via spreadsheet and tabular formats. A technical reader will likely understand this, but others may not. We do a good job on the previous page of clarifying the relationship between the JSON and tabular formats, but I think it bears summarising here (in a single sentence) if someone has jumped to this page or has been linked to it by a colleague. |
Thanks for the comments! For Duncan's points:
For Matt's points:
To accommodate Duncan's feedback, I kept the concepts in the bullets only. See the PR.
Added a link to https://www.open-contracting.org/impact/evidence/ which includes academic research and other evidence.
Linked to https://www.open-contracting.org/resources/demand-side-assessment-report/
The CSV format is non-normative, as it is only described in the guidance. Any effort to make it normative needs to wait for OCDS 1.2. So, it remains true that the only thing that is truly OCDS data is JSON data. I've reworded the previous page to make it clear that the Excel/CSV files are conversions of OCDS data. Regarding a more detailed review, the Primer was tested with 10 users in English and Spanish and reviewed internally by both helpdesk teams in CRM-7157. I expect that, if there are any remaining issues or improvements to be made, then they are minor. We can instead turn our attention to making 1.2 progress and to other 1.1 issues that are more major. |
Great to see that the Primer is live. I noticed a few issues from a quick read-through. Some are readability/copy-editing issues, some are more substantive. Happy to do a more detailed review, if that would be helpful.
https://standard.open-contracting.org/latest/en/primer/
https://standard.open-contracting.org/latest/en/primer/what/
https://standard.open-contracting.org/latest/en/primer/how/
https://standard.open-contracting.org/latest/en/primer/releases_and_records/
tender/documents
etc., but everywhere else on the page 'documents' refers to a release or record JSON document.The text was updated successfully, but these errors were encountered: