-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release schema: Set omitWhenMerged = true on publisher field #1483
Comments
Ah, I see there is a different approach in a PR on Compranet's releasePublisher extension: instead of One challenge to that approach is that if a one publisher sets As such, I think sticking to a single |
Yes, I think |
The specific need was to determine who published a release from the compiled release without checking the original releases. But as Duncan mentioned, following the array approach could lead to incomplete information in the compiled release anyway (when one publisher doesn't use the field) (unless we make the field required, but we can't do that). So yes, we should set |
I'm not sure that many publishers are using linked releases – and when they do, they are typically linking to their own releases, rather than third-party releases. |
Thanks, both. I've opened an issue on CompraNet's extension. @yolile do you want to close your PR? |
Thank you, and done! |
#1376 adds a release-level
publisher
field. However,omitWhenMerged
is not set so in a compiled release the publisher of the most recent release will always appear as the publisher.The text was updated successfully, but these errors were encountered: