Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release schema: Set omitWhenMerged = true on publisher field #1483

Closed
duncandewhurst opened this issue Mar 4, 2022 · 6 comments
Closed

Release schema: Set omitWhenMerged = true on publisher field #1483

duncandewhurst opened this issue Mar 4, 2022 · 6 comments
Assignees
Labels
Milestone

Comments

@duncandewhurst
Copy link
Contributor

#1376 adds a release-level publisher field. However, omitWhenMerged is not set so in a compiled release the publisher of the most recent release will always appear as the publisher.

@duncandewhurst duncandewhurst added this to the 1.2.0 milestone Mar 4, 2022
@duncandewhurst
Copy link
Contributor Author

Ah, I see there is a different approach in a PR on Compranet's releasePublisher extension: instead of publisher make publishers an array, so that the compiled release will have a list of all the publishers.

One challenge to that approach is that if a one publisher sets publishers and another doesn't, then in the compiled release it will look like there is only one publisher.

As such, I think sticking to a single publisher field and setting omitWhenMerged to true is a better solution. Sound good?

@jpmckinney
Copy link
Member

Yes, I think publisher is only useful at release-level, but perhaps @yolile remembers some discussion about making it an array?

@yolile
Copy link
Member

yolile commented Mar 4, 2022

The specific need was to determine who published a release from the compiled release without checking the original releases. But as Duncan mentioned, following the array approach could lead to incomplete information in the compiled release anyway (when one publisher doesn't use the field) (unless we make the field required, but we can't do that). So yes, we should set omitWhenMerged to True and for compiled releases, the users will need to check the original releases. (unless we add the publisher field to the linked releases as well?)

@jpmckinney
Copy link
Member

I'm not sure that many publishers are using linked releases – and when they do, they are typically linking to their own releases, rather than third-party releases.

@duncandewhurst
Copy link
Contributor Author

Thanks, both. I've opened an issue on CompraNet's extension. @yolile do you want to close your PR?

@yolile
Copy link
Member

yolile commented Mar 9, 2022

Thank you, and done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

No branches or pull requests

4 participants