-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update guidance on naming of classification schemes #1690
Comments
Do you mean that the example (2.1) on https://standard.open-contracting.org/staging/1.2-dev/en/guidance/map/organization_classifications/ should be updated to the use the eForms codes/schemes rather than the TED ones? So the admonition should mention both TED and eForms schemes? |
Noting that the examples that will be affected by this are included in #1680 so it's probably best to wait until that PR has been merged before creating a PR for this issue to avoid merge conflicts |
We should update it to eForms, in which case we only have an admonition for the eForms schemes (since the TED schemes will no longer be part of the examples). |
https://standard.open-contracting.org/staging/1.2-dev/en/guidance/map/organization_classifications/
The general guidance ought to be along the lines of:
This is consistent with https://extensions.open-contracting.org/en/extensions/coveredBy/master/#guidance
We should link to the new guidance from https://extensions.open-contracting.org/en/extensions/organizationClassification/master/
In the examples, we should change "COL" to "CO". We can add an admonition about TED_CE_ACTIVITY and TED_CA_TYPE, to explain that they don't conform to our guidance, because we aimed for consistency with the XML elements in the TED Schema. (At the same time, we can update to the 'eu-main-activity' and 'eu-buyer-legal-type' schemes).
Related, we should change this page to use alpha-2: https://standard.open-contracting.org/staging/1.2-dev/en/guidance/map/organization_personal_identifiers/
For reference, https://github.com/open-contracting/standard-maintenance-scripts/blob/main/schema/codelist-schema.json sets the allowed patterns for codes, some of which are relevant for scheme codes:
[A-Z]+[0-9]?
(the only numeric acronym is ISO2 for the ISO 3166-1 alpha-2 gazetteer)([a-z]+|oc4ids)([A-Z][a-z]+|EU|GPP)*(\\.[a-z]+([A-Z][a-z]+)*)?
[A-Z]{2}(-[A-Z]+)+
Exceptional patterns, to match multinational standards:
TED(_[A-Z]+)+
eu(-[a-z]+)+
These patterns are not relevant for scheme codes (they are examples of being consistent with other standards):
date-time
LineString|Point|Polygon|MultiLineString|MultiPoint|MultiPolygon
(application|audio|font|example|image|message|model|multipart|text|video)/[\w.+-]+
The text was updated successfully, but these errors were encountered: