Finishes refactoring libraries APIs#758
Closed
pomegranited wants to merge 7 commits intobraden/units-apifrom
Closed
Finishes refactoring libraries APIs#758pomegranited wants to merge 7 commits intobraden/units-apifrom
pomegranited wants to merge 7 commits intobraden/units-apifrom
Conversation
Code borrowed from cee5722fd73607708a2dce7d70598d57b2fe5bb
Base automatically changed from
jill/units-api-update-delete
to
braden/units-api
March 27, 2025 23:46
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses libraries API TODOs introduced by openedx#36371.
Private ref: FAL-4052
Testing instructions
Should be enough to do a code review and careful check of the tests to ensure they validate the desired behaviour for these new methods.