feat: Adjust library home filter styles #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 26, 2024
| const iconMap = { | ||
| blockType: FilterList, | ||
| tags: Tag, | ||
| }; |
There was a problem hiding this comment.
The SearchFilterWidget is a generic component, and it shouldn't need to know about what type of filters may use it. In other words, it shouldn't need iconMap. Instead, I recommend it just accept an icon prop, and then the widgets like <FilterByBlockType> can pass in icon={FilterList}.
There was a problem hiding this comment.
Good point, thanks for that! I've updated it
yusuf-musleh
force-pushed
the
yusuf-musleh/library-home-filters-styling
branch
from
2ff49f7
to
b4374e9
Compare
rpenido
merged commit 3cc07ae
into
rpenido/fal-3764-library-home-filter-by-content-type
2 of 3 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adjust the styles for the filters present on the Library Home page to closer match the styles in Figma.
Testing Instructions
Private-ref: FAL-3763