Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync DIS2012.xml and DIS7.xml #21

Open
leif81 opened this issue Jun 4, 2019 · 5 comments
Open

Sync DIS2012.xml and DIS7.xml #21

leif81 opened this issue Jun 4, 2019 · 5 comments

Comments

@leif81
Copy link
Member

leif81 commented Jun 4, 2019

The file in this repo, xmlpg/DIS2012.xml and the one over in DISDescription/DIS7.xml differ slightly. They should be the same.

https://github.com/open-dis/xmlpg/blob/master/DIS2012.xml
https://github.com/open-dis/DISDescription/blob/master/DIS7.xml

It looks to me like different fixes have gone into both so a careful merge of the two should be considered.

@leif81
Copy link
Member Author

leif81 commented Jun 4, 2019

To avoid this, there should be only one source for these files.

@kurtsansom
Copy link

Is it possible to make xmlpg generate some kind of time stamp with the git commit for the file used to generate the code?

@leif81
Copy link
Member Author

leif81 commented Jan 22, 2021

@kurtsansom it probably could, that would help identify what was used to generate the code. If this would be useful to you feel free to submit a pull request.

@kurtsansom
Copy link

I would be happy to make some changes. I am not sure where to start. I was able to build, and generate c++, but beyond that my java skills are mediocre.

@leif81
Copy link
Member Author

leif81 commented Feb 12, 2021

@kurtsansom ok, I'd recommend installing Apache Netbeans for your IDE, file open the root folder with the pom.xml.

Accessing the Git sha1 in Java looks like it could be done by adding the maven git commit id plugin to the project and then reading in the properties file it generates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants