Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure that all node Properties are categorized #206

Closed
jonnew opened this issue Aug 13, 2024 · 1 comment · Fixed by #226
Closed

Ensure that all node Properties are categorized #206

jonnew opened this issue Aug 13, 2024 · 1 comment · Fixed by #226
Assignees
@bparks13
Milestone
0.2.0

Comments

@jonnew
Copy link
Member

jonnew commented Aug 13, 2024

All properties that are exposed as parameters of Bonsai operators need to be be tagged with the appropriate Configuration or Acquisition Attribute. For example this should be Acquisition:

https://github.com/open-ephys/onix-bonsai-onix1/blob/7ac700fb8a696d4d9f8d97c9d1b85765b9951ca6/OpenEphys.Onix1/Headstage64ElectricalStimulatorTrigger.cs#L49
@jonnew jonnew added this to the 0.2.0 milestone Aug 13, 2024
@bparks13
Copy link
Member

NeuropixelsV2e and NeuropixelsV2eBeta categories are updated in #214.

@bparks13 bparks13 linked a pull request Aug 20, 2024 that will close this issue
Add Acquisition or Configuration category to public properties #226
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bparks13 bparks13

Labels
None yet
Projects
None yet
Milestone
0.2.0
Development

Successfully merging a pull request may close this issue.

Add Acquisition or Configuration category to public properties open-ephys/bonsai-onix1
2 participants
@jonnew @bparks13