Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Channel configurations do not respect file properties on load #271

Closed
bparks13 opened this issue Aug 28, 2024 · 0 comments · Fixed by #272
Closed

Channel configurations do not respect file properties on load #271

bparks13 opened this issue Aug 28, 2024 · 0 comments · Fixed by #272
Assignees
Labels
bug Something isn't working
Milestone

Comments

@bparks13
Copy link
Member

NeuropixelsV2QuadShankProbeConfiguration and NeuropixelsV1eProbeConfiguration both have an issue when loading an existing file. What happens is that the DeviceChannelIndices field is pulled out and then saved, but the rest of the fields are discarded. This is due to how I am creating a deep-copy; to fix it, I will need to update OpenEphys.ProbeInterface.NET to create clones of the fields, or use the newly modified public Probe copy constructor as a way to copy the whole probe without keeping the pointer reference.

This is currently being fixed in the issue-252 branch.

@bparks13 bparks13 added the bug Something isn't working label Aug 28, 2024
@bparks13 bparks13 added this to the 0.3.0 milestone Aug 28, 2024
@bparks13 bparks13 self-assigned this Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant