feat: Support retrieving numeric metadata as either integers or decimals (#490)

* feat: Support retrieving numeric metadata as either either integers or decimals #443

Signed-off-by: Otto Lagerquist <otto_nr26@hotmail.com>
Signed-off-by: lager95 <33402278+lager95@users.noreply.github.com>

* Update ImmutableMetadata.cs

Updated document comments to reflect the conversions between int and double.

Signed-off-by: lager95 <33402278+lager95@users.noreply.github.com>

---------

Signed-off-by: Otto Lagerquist <otto_nr26@hotmail.com>
Signed-off-by: lager95 <33402278+lager95@users.noreply.github.com>
Co-authored-by: Michael Beemer <beeme1mr@users.noreply.github.com>
Co-authored-by: Todd Baert <todd.baert@dynatrace.com>

Author: 3 people

src/OpenFeature/Model/ImmutableMetadata.cs

@@ -42,20 +42,32 @@ public ImmutableMetadata(Dictionary<string, object> metadata)
     /// Gets the integer value associated with the specified key.
     /// </summary>
     /// <param name="key">The key of the value to retrieve.</param>
-    /// <returns>The integer value associated with the key, or null if the key is not found.</returns>
+    /// <returns>The value associated with the key as an integer, if it is of type double or int; otherwise, null.</returns>
     public int? GetInt(string key)
     {
-        return this.GetValue<int>(key);
+        var hasValue = this._metadata.TryGetValue(key, out var value);
+        if (!hasValue)
+        {
+            return null;
+        }
+
+        return value is double || value is int ? Convert.ToInt32(value) : null;
     }
 
     /// <summary>
     /// Gets the double value associated with the specified key.
     /// </summary>
     /// <param name="key">The key of the value to retrieve.</param>
-    /// <returns>The double value associated with the key, or null if the key is not found.</returns>
+    /// <returns>The value associated with the key as a double, if it is of type double or int; otherwise, null.</returns>
     public double? GetDouble(string key)
     {
-        return this.GetValue<double>(key);
+        var hasValue = this._metadata.TryGetValue(key, out var value);
+        if (!hasValue)
+        {
+            return null;
+        }
+
+        return value is double || value is int ? Convert.ToDouble(value) : null;
     }
 
     /// <summary>

test/OpenFeature.Tests/ImmutableMetadataTest.cs

@@ -100,6 +100,28 @@ public void GetInt_Should_Return_Value_If_Key_Found()
         Assert.NotNull(result);
         Assert.Equal(1, result);
     }
+    [Fact]
+    [Specification("1.4.14",
+        "If the `flag metadata` field in the `flag resolution` structure returned by the configured `provider` is set, the `evaluation details` structure's `flag metadata` field MUST contain that value. Otherwise, it MUST contain an empty record.")]
+    [Specification("1.4.14.1", "Condition: `Flag metadata` MUST be immutable.")]
+    public void GetInt_Should_Return_Value_If_Key_Found_although_double()
+    {
+        // Arrange
+        var metadata = new Dictionary<string, object>
+        {
+            {
+                "intKey", 1.0
+            }
+        };
+        var flagMetadata = new ImmutableMetadata(metadata);
+
+        // Act
+        var result = flagMetadata.GetInt("intKey");
+
+        // Assert
+        Assert.NotNull(result);
+        Assert.Equal(1, result);
+    }
 
     [Fact]
     [Specification("1.4.14",
@@ -160,6 +182,29 @@ public void GetDouble_Should_Return_Value_If_Key_Found()
         Assert.Equal(1.2, result);
     }
 
+    [Fact]
+    [Specification("1.4.14",
+        "If the `flag metadata` field in the `flag resolution` structure returned by the configured `provider` is set, the `evaluation details` structure's `flag metadata` field MUST contain that value. Otherwise, it MUST contain an empty record.")]
+    [Specification("1.4.14.1", "Condition: `Flag metadata` MUST be immutable.")]
+    public void GetDouble_Should_Return_Value_If_Key_Found_Although_Int()
+    {
+        // Arrange
+        var metadata = new Dictionary<string, object>
+        {
+            {
+                "doubleKey", 1
+            }
+        };
+        var flagMetadata = new ImmutableMetadata(metadata);
+
+        // Act
+        var result = flagMetadata.GetDouble("doubleKey");
+
+        // Assert
+        Assert.NotNull(result);
+        Assert.Equal(1.0, result);
+    }
+
     [Fact]
     [Specification("1.4.14",
         "If the `flag metadata` field in the `flag resolution` structure returned by the configured `provider` is set, the `evaluation details` structure's `flag metadata` field MUST contain that value. Otherwise, it MUST contain an empty record.")]