Skip to content

Conversation

@WeihanLi
Copy link
Contributor

@WeihanLi WeihanLi commented Jul 22, 2025

This PR

  • add ValueJsonConverter to support STJ JSON Serialize

Related Issues

Fixes #517

Notes

  • Add ValueJsonConverter to support STJ JSON Serialize, keep it internal for now, think we could make it public when necessary

Follow-up Tasks

  • Do we need to add a ToJsonString() method likes LD SDK?
  • Do we need to add a method to convert Value to a strong-typed T?

How to test

refer to the unit test cases

Signed-off-by: Weihan Li <weihanli@outlook.com>
@codecov
Copy link

codecov bot commented Jul 22, 2025

Codecov Report

Attention: Patch coverage is 96.10390% with 3 lines in your changes missing coverage. Please review.

Project coverage is 88.18%. Comparing base (a0ae014) to head (909377b).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/OpenFeature/Model/ValueJsonConverter.cs 96.10% 0 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #529      +/-   ##
==========================================
+ Coverage   87.88%   88.18%   +0.30%     
==========================================
  Files          48       49       +1     
  Lines        1972     2049      +77     
  Branches      222      239      +17     
==========================================
+ Hits         1733     1807      +74     
  Misses        191      191              
- Partials       48       51       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

WeihanLi added 2 commits July 22, 2025 23:37
Signed-off-by: Weihan Li <weihanli@outlook.com>
Signed-off-by: Weihan Li <weihanli@outlook.com>
@WeihanLi WeihanLi changed the title Support JSON Serialize for Value feat: Support JSON Serialize for Value Jul 22, 2025
WeihanLi added 5 commits July 23, 2025 08:17
Signed-off-by: Weihan Li <weihanli@outlook.com>
Signed-off-by: Weihan Li <weihanli@outlook.com>
Signed-off-by: Weihan Li <weihanli@outlook.com>
Signed-off-by: Weihan Li <weihanli@outlook.com>
Signed-off-by: Weihan Li <weihanli@outlook.com>
@WeihanLi WeihanLi force-pushed the value-to-json-string branch from 5f8cb12 to 7c217aa Compare July 23, 2025 11:40
@WeihanLi WeihanLi marked this pull request as ready for review July 23, 2025 12:02
@WeihanLi WeihanLi requested a review from a team as a code owner July 23, 2025 12:02
WeihanLi added 2 commits July 24, 2025 09:09
…st data

Signed-off-by: Weihan Li <weihanli@outlook.com>
Signed-off-by: Weihan Li <weihanli@outlook.com>
@WeihanLi WeihanLi force-pushed the value-to-json-string branch from cdf97d4 to 2ca8dd0 Compare July 24, 2025 01:19
WeihanLi added 3 commits July 24, 2025 09:35
Signed-off-by: Weihan Li <weihanli@outlook.com>
Signed-off-by: Weihan Li <weihanli@outlook.com>
Signed-off-by: Weihan Li <weihanli@outlook.com>
Signed-off-by: Weihan Li <weihanli@outlook.com>
Copy link
Member

@askpt askpt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for your contribution.

@askpt askpt added this pull request to the merge queue Jul 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Best practices to use JSON value

3 participants