-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add TransactionContext #283
feat: add TransactionContext #283
Conversation
Signed-off-by: Kevin Schoonover <me@kschoon.me>
36ff6ae
to
4d08b89
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #283 +/- ##
==========================================
+ Coverage 81.92% 82.12% +0.20%
==========================================
Files 10 10
Lines 979 990 +11
==========================================
+ Hits 802 813 +11
Misses 156 156
Partials 21 21 ☔ View full report in Codecov by Sentry. |
Hey @kevinschoonover, could you please update the readme to include a section about this? Please follow the template found here. Thanks! |
Yes, I agree. Currently, all implementations override existing transaction context, but adding another method that merges would be useful. |
Signed-off-by: Kevin Schoonover <me@kschoon.me>
Signed-off-by: Kevin Schoonover <me@kschoon.me>
Done!
Added a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great, thanks! I'll defer the final review to a Go expert but it looks good to me.
Signed-off-by: Kevin Schoonover <me@kschoon.me>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me. All my suggestions are non-blocking.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks really good to me!
Co-authored-by: Evan Bradley <11745660+evan-bradley@users.noreply.github.com> Signed-off-by: Kevin Schoonover <schoonoverkevinm@gmail.com>
Signed-off-by: Kevin Schoonover <me@kschoon.me>
55dad60
to
b28ad6f
Compare
This PR
The functions that are important are
Related Issues
#256
Notes
For next steps,
WithTransactionContext
multiple times. My guess is we should expect the user to handle this on their end, but would be interested in opinions on if WithTransactionContext should merge existing TransactionContextsHow to test
I updated the associated tests for merging order / evaluation. Please let me know if any other tests will be helpful!