Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] flaky unit test(s) #308

Closed
warber opened this issue Nov 28, 2024 · 0 comments · Fixed by #309
Closed

[BUG] flaky unit test(s) #308

warber opened this issue Nov 28, 2024 · 0 comments · Fixed by #309
Labels
bug Something isn't working Needs Triage

Comments

@warber
Copy link
Contributor

warber commented Nov 28, 2024 •
edited
Loading

Observed behavior

One unit test (TestEventHandler_ProviderReadiness) appears to be flaky, intermittently failing under certain conditions.

--- FAIL: TestEventHandler_ProviderReadiness (0.60s)
    --- FAIL: TestEventHandler_ProviderReadiness/for_unassociated_handler_from_default (0.20s)
        event_executor_test.go:742: timedout waiting for ready state callback, but got none

Expected Behavior

All tests pass

Steps to reproduce

Run the test e.g. 200 times:

go test-run ^TestEventHandler_ProviderReadiness$  -count 200
--- FAIL: TestEventHandler_ProviderReadiness (0.60s)
    --- FAIL: TestEventHandler_ProviderReadiness/for_unassociated_handler_from_default (0.20s)
        event_executor_test.go:742: timedout waiting for ready state callback, but got none
--- FAIL: TestEventHandler_ProviderReadiness (0.60s)
    --- FAIL: TestEventHandler_ProviderReadiness/for_unassociated_handler_from_default (0.20s)
        event_executor_test.go:742: timedout waiting for ready state callback, but got none
--- FAIL: TestEventHandler_ProviderReadiness (0.60s)
    --- FAIL: TestEventHandler_ProviderReadiness/for_unassociated_handler_from_default (0.20s)
        event_executor_test.go:742: timedout waiting for ready state callback, but got none
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working Needs Triage
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: consider default client when loading states warber/go-sdk
1 participant
@warber