Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: RejectedExecutionException on shutdown #652

Merged
merged 1 commit into from
Oct 12, 2023

Conversation

toddbaert
Copy link
Member

@toddbaert toddbaert commented Oct 12, 2023

  • don't reset noop provider on ProviderRepository shutdown, not necessary anyway since we create a whole new ProviderRepository on shutdown
  • updated related tests

@Kavindu-Dodan you were exactly right on the cause.

Fixes: #647

Signed-off-by: Todd Baert <todd.baert@dynatrace.com>
@toddbaert toddbaert requested a review from a team as a code owner October 12, 2023 20:04
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov
Copy link

codecov bot commented Oct 12, 2023

Codecov Report

Merging #652 (c62fd11) into main (b77e44e) will increase coverage by 0.32%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main     #652      +/-   ##
============================================
+ Coverage     94.45%   94.78%   +0.32%     
+ Complexity      360      358       -2     
============================================
  Files            32       32              
  Lines           848      843       -5     
  Branches         52       52              
============================================
- Hits            801      799       -2     
+ Misses           25       23       -2     
+ Partials         22       21       -1     
Flag Coverage Δ
unittests 94.78% <ø> (+0.32%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...n/java/dev/openfeature/sdk/ProviderRepository.java 98.43% <ø> (+1.33%) ⬆️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@toddbaert toddbaert merged commit 8c595b0 into main Oct 12, 2023
@toddbaert toddbaert deleted the fix/RejectedExecutionException branch October 12, 2023 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RejectedExecutionException after shutdown
3 participants