Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: implement spec 0.7.0 changes #655

Merged
merged 10 commits into from
Oct 23, 2023
Merged

feat: implement spec 0.7.0 changes #655

merged 10 commits into from
Oct 23, 2023

Conversation

toddbaert
Copy link
Member

@toddbaert toddbaert commented Oct 13, 2023 •
edited
Loading

  • run any event handler immediately if the provider is in the associated state, not just ready
  • add providerName to event details
  • add STALE provider state
  • update/add associated tests
  • also fixed spec/test associations mismatches from previous changes

fixes: #599

@toddbaert
feat: implement spec 0.7.0 changes
53c250a 
* run any event handler immediately if the provider is in the associated state, not just ready
* add prividerName to event details
* add STALE provider state
* update/add associated tests
* also fixed spec/test associations mismatches from previous changes

Signed-off-by: Todd Baert <todd.baert@dynatrace.com>
@toddbaert toddbaert requested a review from a team as a code owner October 13, 2023 20:23
@codecov
Copy link

codecov bot commented Oct 13, 2023 •
edited
Loading

Codecov Report

Merging #655 (f89319b) into main (fb4d369) will increase coverage by 0.16%.
The diff coverage is 95.00%.

@@             Coverage Diff              @@
##               main     #655      +/-   ##
============================================
+ Coverage     94.54%   94.71%   +0.16%     
- Complexity      357      363       +6     
============================================
  Files            32       32              
  Lines           843      851       +8     
  Branches         52       51       -1     
============================================
+ Hits            797      806       +9     
+ Misses           24       23       -1     
  Partials         22       22
Flag Coverage Δ
unittests 94.71% <95.00%> (+0.16%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...rc/main/java/dev/openfeature/sdk/EventDetails.java 100.00% <100.00%> (ø)
...ava/dev/openfeature/sdk/FlagEvaluationDetails.java 100.00% <100.00%> (ø)
.../main/java/dev/openfeature/sdk/OpenFeatureAPI.java 100.00% <100.00%> (ø)
...c/main/java/dev/openfeature/sdk/ProviderState.java 66.66% <50.00%> (-33.34%) ⬇️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Kavindu-Dodan
Kavindu-Dodan approved these changes Oct 16, 2023
View reviewed changes
Copy link
Contributor

@Kavindu-Dodan Kavindu-Dodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Left a minor remark on a code comment, the rest looks great .! Specially thanks for checking unit tests and fixing spec references.

@toddbaert
Update src/main/java/dev/openfeature/sdk/OpenFeatureAPI.java
73ef1b4 
Signed-off-by: Todd Baert <todd.baert@dynatrace.com>
@toddbaert @thiyagu06
Update src/main/java/dev/openfeature/sdk/EventDetails.java
a665e9e 
Co-authored-by: Thiyagu GK <thiyagu103@gmail.com>
Signed-off-by: Todd Baert <todd.baert@dynatrace.com>
@toddbaert toddbaert requested a review from thiyagu06 October 18, 2023 14:52
@toddbaert toddbaert force-pushed the feat/0.7.0 branch 3 times, most recently from 7786121 to 217e733 Compare October 18, 2023 18:02
@toddbaert
fixup: flaky tests
217e733 
Signed-off-by: Todd Baert <todd.baert@dynatrace.com>
@beeme1mr
Copy link
Member

Let's try and merge this tomorrow unless someone identifies a blocker.

@toddbaert
Copy link
Member Author

@thiyagu06 I've accepted the change you proposed. Can you re-review?

thiyagu06
thiyagu06 approved these changes Oct 20, 2023
View reviewed changes
Copy link
Member

@thiyagu06 thiyagu06 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 5 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@toddbaert toddbaert merged commit fe5a20f into main Oct 23, 2023
@toddbaert toddbaert deleted the feat/0.7.0 branch October 23, 2023 14:04
@github-actions github-actions bot mentioned this pull request Oct 23, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kavindu-Dodan Kavindu-Dodan Kavindu-Dodan approved these changes

@thiyagu06 thiyagu06 thiyagu06 approved these changes

@beeme1mr beeme1mr beeme1mr approved these changes

@justinabrahms justinabrahms Awaiting requested review from justinabrahms

@thomaspoignant thomaspoignant Awaiting requested review from thomaspoignant

@liran2000 liran2000 Awaiting requested review from liran2000

@DBlanchard88 DBlanchard88 Awaiting requested review from DBlanchard88

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Conform to spec v0.7.0
4 participants
@toddbaert @beeme1mr @thiyagu06 @Kavindu-Dodan