fix: tolerate duplicate provider registrations #725
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kavindu-Dodan
commented
Dec 11, 2023
Kavindu-Dodan
commented
Dec 11, 2023
src/test/java/dev/openfeature/sdk/testutils/FeatureProviderTestUtils.java
Show resolved
Hide resolved
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #725 +/- ##
============================================
+ Coverage 94.74% 95.09% +0.35%
- Complexity 364 366 +2
============================================
Files 33 33
Lines 856 857 +1
Branches 52 53 +1
============================================
+ Hits 811 815 +4
+ Misses 23 22 -1
+ Partials 22 20 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
toddbaert
reviewed
Dec 11, 2023
beeme1mr
changed the title
toddbaert
changed the title
toddbaert
changed the title
toddbaert
requested review from
justinabrahms,
thisthat,
thiyagu06 and
thomaspoignant
Kavindu-Dodan
force-pushed
the
fix/provider-registration
branch
from
f03e980
to
f82228f
Compare
thisthat
reviewed
Dec 12, 2023
Signed-off-by: Kavindu Dodanduwa <kavindudodanduwa@gmail.com>
Signed-off-by: Kavindu Dodanduwa <kavindudodanduwa@gmail.com>
Kavindu-Dodan
force-pushed
the
fix/provider-registration
branch
from
f0c8213
to
ce201d1
Compare
|
beeme1mr
approved these changes
Dec 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
Fixes a bug that prevented the same provider from being registered with multiple names (or the same provider as default and with another name).
Note that I have not changed the behavior of
EventProvider.javawhere it throws if multiple eventing attachments were attempted be to registered.