fix: setProviderAndWait must throw #794
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toddbaert
commented
Feb 7, 2024
| this::emitReady, | ||
| this::detachEventProvider, | ||
| this::emitError, | ||
| this::emitErrorAndThrow, |
There was a problem hiding this comment.
This is the main change - I pass a new delegate which not only emits the events, but throws.
toddbaert
requested review from
Kavindu-Dodan,
beeme1mr,
justinabrahms,
liran2000 and
thisthat
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #794 +/- ##
============================================
+ Coverage 94.87% 95.13% +0.26%
- Complexity 366 368 +2
============================================
Files 34 34
Lines 858 863 +5
Branches 53 53
============================================
+ Hits 814 821 +7
+ Misses 23 22 -1
+ Partials 21 20 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
toddbaert
force-pushed
the
set-and-wait-throw
branch
from
ee1d18b to
9f453ba
Compare
Signed-off-by: Todd Baert <todd.baert@dynatrace.com>
toddbaert
commented
Feb 7, 2024
| ProviderEventDetails.builder().message(exception.getMessage()).build()); | ||
| } | ||
|
|
||
| private void emitErrorAndThrow(FeatureProvider provider, OpenFeatureError exception) throws OpenFeatureError { |
There was a problem hiding this comment.
New delegate which emits errors but also throws.
beeme1mr
approved these changes
Feb 7, 2024
liran2000
approved these changes
Feb 8, 2024
|
Kavindu-Dodan
approved these changes
Feb 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per 1.1.2.4, the blocking provider setter must throw if init fails, so that application integrators can easily understand if their provider is working without attaching event handlers.
We implemented the wait functionality of this method, but we swallow the exception.
This PR fixes that.