fix: consistent method chainability #913
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: DBlanchard88 <davidblanchard88@gmail.com>
Signed-off-by: DBlanchard88 <davidblanchard88@gmail.com>
Signed-off-by: DBlanchard88 <davidblanchard88@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #913 +/- ##
============================================
+ Coverage 94.98% 95.21% +0.22%
- Complexity 383 384 +1
============================================
Files 36 36
Lines 877 877
Branches 53 53
============================================
+ Hits 833 835 +2
+ Misses 24 23 -1
+ Partials 20 19 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
toddbaert
requested review from
beeme1mr,
thisthat,
thiyagu06,
Kavindu-Dodan,
thomaspoignant and
toddbaert
toddbaert
reviewed
May 1, 2024
toddbaert
approved these changes
May 1, 2024
Signed-off-by: Todd Baert <todd.baert@dynatrace.com>
|
I'll merge this tomorrow at the latest unless anyone has objections. |
beeme1mr
approved these changes
May 1, 2024
thisthat
approved these changes
May 2, 2024
|
toddbaert
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-Client Interface: Modified
setEvaluationContextandaddHooksto returnClientinstances, enabling chaining.-MutableContext: Updated
setTargetingKeyto return aMutableContextinstance.-OpenFeatureAPI: Altered
setEvaluationContextto returnOpenFeatureAPIinstances.-OpenFeatureClient: Updated both
addHooksandsetEvaluationContextto returnOpenFeatureClientinstances.-Added unit tests to verify chainability for each updated method.
Fixes: #906