feat: Accept timeout for LD waitForInitialization #1117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RedbackThomson
changed the title
kinyoklion
approved these changes
Dec 13, 2024
|
@RedbackThomson You will need to sign-off on your commit. You should be able to amend your commit with the signoff. |
Signed-off-by: Nicholas Thomson <RedbackThomson@users.noreply.github.com>
RedbackThomson
force-pushed
the
ld-initialization-timeout
branch
from
351fd14 to
ff8d356
Compare
|
Done and force-pushed |
toddbaert
approved these changes
Dec 17, 2024
toddbaert
changed the title
|
Available with #935 merge (merging now) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new option to the LaunchDarkly provider constructor,
initializationTimeout, which lets users optionally configure the timeout used in the LDClientwaitForInitializationmethod. This timeout is critical because it otherwise would cause the LDClient to hang indefinitely in cases where the network connection cannot be established.