Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update OpenFeature core version to 1.5.0 #1077

Merged
merged 2 commits into from
Nov 7, 2024
Merged

Conversation

beeme1mr
Copy link
Member

@beeme1mr beeme1mr commented Nov 6, 2024

This PR

  • bumps OpenFeature core version to match the current release

Notes

This should have been automatically by the CI but it didn't work for some reason. I'll look into why after the issue is resolved.

fe3ad8e#diff-e35631c960979816b4b2bda7950788e968930fcaf2cf39b482ff23117cd13888R50

Signed-off-by: Michael Beemer <beeme1mr@users.noreply.github.com>
@beeme1mr beeme1mr requested a review from a team as a code owner November 6, 2024 20:48
@beeme1mr
Copy link
Member Author

beeme1mr commented Nov 6, 2024

The script to bump the peer version is very inconsistent but I'm not sure why. The web SDK fairly constantly has the dev dependency version bumped but not the peer version. Running the script again properly bumps the peer. If I update the root package.json to update web before server, the server peer version isn't bumped. It must be some very odd race condition. Any ideas @toddbaert @lukas-reining?

@beeme1mr
Copy link
Member Author

beeme1mr commented Nov 6, 2024

We may want to loosen the peer dependency requirements if possible. It's a bit painful to run both the server and web SDK in a single project due to constant version mismatches.

@toddbaert
Copy link
Member

We may want to loosen the peer dependency requirements if possible. It's a bit painful to run both the server and web SDK in a single project due to constant version mismatches.

It's not possible without introducing significant risk.

@toddbaert toddbaert merged commit a3469b6 into main Nov 7, 2024
8 checks passed
@toddbaert toddbaert deleted the beeme1mr-patch-4 branch November 7, 2024 13:34
toddbaert pushed a commit that referenced this pull request Nov 7, 2024
🤖 I have created a release *beep* *boop*
---


##
[1.3.2](web-sdk-v1.3.1...web-sdk-v1.3.2)
(2024-11-07)


### 🐛 Bug Fixes

* update OpenFeature core version to 1.5.0
([#1077](#1077))
([a3469b6](a3469b6))


### 🧹 Chore

* loosen peer dependency requirements, remove some ci automation
([#1080](#1080))
([ef3ba21](ef3ba21))


### 🚀 Performance

* avoid using exceptions for flow control
([#1074](#1074))
([26264d6](26264d6))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Signed-off-by: OpenFeature Bot <109696520+openfeaturebot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants