fix: return metadata for the bound provider in hookContext #883
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Good catch! Could you please add some tests so that we can ensure we don't accidentally introduce a regression? |
Member
Agreed on this one, but if you have any trouble let me know and I'll happily add them myself; I know you're usually our "Python guy" so feel free to let me know if adding those tests is too tedious! |
federicobond
force-pushed
the
fix/hookcontext-metadata
branch
3 times, most recently
from
27b2c1b to
ba0f4cf
Compare
Clients were incorrectly populating the hook context provider metadata field with metadata from the default provider instead of the one bound to the client. Signed-off-by: Federico Bond <federicobond@gmail.com>
federicobond
force-pushed
the
fix/hookcontext-metadata
branch
from
ba0f4cf to
a6ac8c6
Compare
Member
Author
|
Would something like this work? I wasn't sure where to put the mock provider definition. |
toddbaert
approved these changes
Mar 26, 2024
This was referenced Mar 26, 2024
toddbaert
pushed a commit
that referenced
this pull request
Apr 2, 2024
🤖 I have created a release *beep* *boop* --- ## [1.0.2](web-sdk-v1.0.1...web-sdk-v1.0.2) (2024-04-02) ### 🐛 Bug Fixes * return metadata for the bound provider in hookContext ([#883](#883)) ([fd84025](fd84025)) ### 🧹 Chore * **main:** release core 1.1.0 ([#899](#899)) ([b3e5f7e](b3e5f7e)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Signed-off-by: OpenFeature Bot <109696520+openfeaturebot@users.noreply.github.com>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Apr 2, 2024
🤖 I have created a release *beep* *boop* --- ## [1.13.4](server-sdk-v1.13.3...server-sdk-v1.13.4) (2024-04-02) ### 🐛 Bug Fixes * return metadata for the bound provider in hookContext ([#883](#883)) ([fd84025](fd84025)) ### 🧹 Chore * **main:** release core 1.1.0 ([#899](#899)) ([b3e5f7e](b3e5f7e)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Signed-off-by: OpenFeature Bot <109696520+openfeaturebot@users.noreply.github.com> Signed-off-by: Todd Baert <todd.baert@dynatrace.com> Co-authored-by: Todd Baert <todd.baert@dynatrace.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clients were incorrectly populating the hook context provider metadata field with metadata from the default provider instead of the one bound to the client.