Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SDK to be compliant with spec v0.5.0 #2

Closed
1 task done
beeme1mr opened this issue Sep 27, 2022 · 4 comments
Closed
1 task done

Update SDK to be compliant with spec v0.5.0 #2

beeme1mr opened this issue Sep 27, 2022 · 4 comments
Assignees

Comments

@beeme1mr
Copy link
Member

beeme1mr commented Sep 27, 2022

Update the SDK to be compliant with the v0.5.0 spec.

What's Changed

⚠ BREAKING CHANGES

Additional changes

General

  • Add/update a spec version badge on the readme.

Specification

Full Changelog: open-feature/spec@v0.4.0...v0.5.0

@tcarrio
Copy link
Member

tcarrio commented Sep 28, 2022

The biggest change I see here is the inclusion of the Error enums

@beeme1mr
Copy link
Member Author

Yeah, it looks like reason is already a string in the PHP implementation. That was also a breaking change in other SDKs which is why we clarified the requirement in the spec.

@tcarrio
Copy link
Member

tcarrio commented Oct 10, 2022

ErrorCode is implemented as an "enum" (supporting PHP 7.4 and 8.0 which do not have native Enums)

@tcarrio
Copy link
Member

tcarrio commented Oct 30, 2022

As far as I can tell this is complete 👍

@tcarrio tcarrio closed this as completed Oct 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants