feat: use Nest.js SDK in backend #273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lukas Reining <lukas.reining@codecentric.de>
lukas-reining
force-pushed
the
feat/nestjs-sdk
branch
from
16589ef
to
3ca03fe
Compare
beeme1mr
reviewed
Jan 19, 2024
|
Yes @beeme1mr, building it locally and running worked! |
Signed-off-by: Lukas Reining <lukas.reining@codecentric.de>
lukas-reining
force-pushed
the
feat/nestjs-sdk
branch
from
8abd2c6
to
6666ad2
Compare
|
I updated the imports @toddbaert @beeme1mr :) |
beeme1mr
reviewed
Jan 22, 2024
| # build: | ||
| # dockerfile: ./packages/app/Dockerfile | ||
| # context: . | ||
| # image: ghcr.io/open-feature/playground-app:v0.13.4 # x-release-please-version |
There was a problem hiding this comment.
Please revert this before merging
Signed-off-by: Michael Beemer <beeme1mr@users.noreply.github.com>
Signed-off-by: Michael Beemer <beeme1mr@users.noreply.github.com>
Signed-off-by: Michael Beemer <beeme1mr@users.noreply.github.com>
Signed-off-by: Michael Beemer <beeme1mr@users.noreply.github.com>
beeme1mr
approved these changes
Jan 22, 2024
I found the issue. There was a shared library that was used both on the client and server but was importing from the Nest SDK. I've updated the imports and added a linting rule to prevent it from happening in the future. |
Signed-off-by: Michael Beemer <beeme1mr@users.noreply.github.com>
Mh interesting, I could build it with the former |
beeme1mr
pushed a commit
that referenced
this pull request
Jan 22, 2024
🤖 I have created a release *beep* *boop* --- ## [0.14.0](v0.13.4...v0.14.0) (2024-01-22) ### 🐛 Bug Fixes * **deps:** update dependency @harnessio/ff-javascript-client-sdk to v1.21.0 ([1ae889f](1ae889f)) * **deps:** update dependency @openfeature/open-telemetry-hooks to ^0.3.0 ([#264](#264)) ([10ec74b](10ec74b)) * **deps:** update dependency flagsmith-nodejs to v3 ([#226](#226)) ([ddaba6d](ddaba6d)) * **deps:** update dependency react-router-dom to v6.20.1 ([e233ccb](e233ccb)) * docker-compose.yaml image instead of build ([#274](#274)) ([2fc3ccb](2fc3ccb)) ### ✨ New Features * client-side flags in e2e k8s demo ([#267](#267)) ([c782315](c782315)) * use Nest.js SDK in backend ([#273](#273)) ([d4b18d8](d4b18d8)) ### 🧹 Chore * **deps:** update dependency @emotion/react to v11.11.3 ([f44f35c](f44f35c)) * **deps:** update dependency @mui/material to v5.14.20 ([8a0a90b](8a0a90b)) * **deps:** update dependency @mui/material to v5.15.6 ([919102d](919102d)) * **deps:** update dependency @types/node to v18.19.3 ([75da9ab](75da9ab)) * **deps:** update dependency core-js to v3.34.0 ([d6133d4](d6133d4)) * **deps:** update dependency ts-node to v10.9.2 ([fba8985](fba8985)) * **deps:** update dependency typescript to v5.3.3 ([58e00be](58e00be)) * **deps:** update eslint ([a32d0fd](a32d0fd)) * **deps:** update ghcr.io/open-feature/flagd docker tag to v0.7.2 ([424fe2f](424fe2f)) * **deps:** update jaegertracing/all-in-one docker tag to v1.52.0 ([aa2afbe](aa2afbe)) * **deps:** update prom/prometheus docker tag to v2.48.1 ([1827862](1827862)) * **deps:** update types ([721b4e8](721b4e8)) * various dep updates ([#271](#271)) ([9764184](9764184)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
Adds the Nest.js SDK to the backend services.