-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add Flipt to playground #293
Conversation
Signed-off-by: Lukas Reining <lukas.reining@codecentric.de>
cheers @lukas-reining !! thank you very much for adding Flipt to the playground! I'm having trouble finding Flipt in the list of providers in the playground to switch between, am I doing something wrong? Note: I can access the Flipt UI and see that the flags / sqlite data has been imported correctly |
Hey @markphelps, I guess you will need to comment out the image in the services:
demo:
image: ghcr.io/open-feature/playground-app:v0.15.2 # x-release-please-version
# build:
# dockerfile: ./packages/app/Dockerfile
# context: . to services:
demo:
# image: ghcr.io/open-feature/playground-app:v0.15.2 # x-release-please-version
build:
dockerfile: ./packages/app/Dockerfile
context: . Does it work now? :) |
silly me, yes works great now thank you! one idea instead of requiring users to copy over the sqlite db before running we do this in our examples via an it might be a bit more portable this way, but im happy either way 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you @lukas-reining !! looks great
Signed-off-by: Lukas Reining <lukas.reining@codecentric.de>
Oh I have completely overseen the import function. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
double approve
I'm not able to get it working locally. Flipt errors getting the db driver for dqlite. Here's what I'm seeing the logs.
The init script is also trying to mount |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
couple things related to @beeme1mr 's comments
Signed-off-by: Lukas Reining <lukas.reining@codecentric.de>
Yes, these were wrong, I completely oversaw those after changing to the import feature @markphelps. |
The error message is:
It looks like we're missing |
Signed-off-by: Lukas Reining <lukas.reining@codecentric.de>
a2e240c
to
659dbe3
Compare
Signed-off-by: Michael Beemer <beeme1mr@users.noreply.github.com>
It's working for me now. Please try my changes to make sure it works for others. |
Works for me too @beeme1mr! :) |
🤖 I have created a release *beep* *boop* --- ## [0.16.0](v0.15.2...v0.16.0) (2024-05-22) ### 🐛 Bug Fixes * **deps:** update dependency flagsmith-nodejs to v3.3.0 ([d4a4468](d4a4468)) ### ✨ New Features * add Flipt to playground ([#293](#293)) ([ab99a8e](ab99a8e)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This PR
Adds Flipt to the playground as discussed with @markphelps.
@markphelps for being able to show "live changing" of flags I chose not to use the read-only mode with static flag definitions.
I chose to use SQLite and created a copy of a DB with configured flags that can be copied before doing
docker compose up
.Otherwise Flipt works great with the Playground and is a great addition for showing live changes in an UI.