Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve logging setup #261

Merged
merged 1 commit into from
Jan 27, 2024
Merged

Conversation

federicobond
Copy link
Member

@federicobond federicobond commented Jan 17, 2024

This PR

Replaces the root logger with a custom logger for all logs emitted by the package.

I believe this should cover the logging requirements for the SDK, since logs can be manipulated later via handlers and formatters using the standard library logging package interface.

Follow-up Tasks

  • If we agree, mark this package as supporting logging configuration in the README.

Copy link

codecov bot commented Jan 17, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (15ce8f9) 93.84% compared to head (bab6c03) 93.89%.

Files Patch % Lines
openfeature/client.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #261      +/-   ##
==========================================
+ Coverage   93.84%   93.89%   +0.04%     
==========================================
  Files          16       16              
  Lines         439      442       +3     
==========================================
+ Hits          412      415       +3     
  Misses         27       27              
Flag Coverage Δ
unittests 93.89% <75.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@gruebel gruebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Signed-off-by: Federico Bond <federicobond@gmail.com>
@federicobond federicobond merged commit ccbff2c into open-feature:main Jan 27, 2024
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants