-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: add support for domains #271
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #271 +/- ##
==========================================
+ Coverage 94.40% 94.52% +0.11%
==========================================
Files 17 18 +1
Lines 447 493 +46
==========================================
+ Hits 422 466 +44
- Misses 25 27 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Due to the argument renaming it becomes a breaking change and then you actually could completely get rid of _provider
and initialize _providers
like this
_providers: typing.Dict[typing.Optional[str], AbstractProvider] = {None: NoOpProvider()}
531831a
to
4d2dfdc
Compare
I introduced a ProviderRegistry in the last commit similar to the ones in other SDKs because the code was becoming a bit convoluted. |
b71012e
to
376802e
Compare
Rebased on top of latest |
376802e
to
11feec1
Compare
acac4dd
to
d1cc64c
Compare
Signed-off-by: Federico Bond <federicobond@gmail.com>
Signed-off-by: Federico Bond <federicobond@gmail.com>
Signed-off-by: Federico Bond <federicobond@gmail.com>
Signed-off-by: Federico Bond <federicobond@gmail.com>
Signed-off-by: Federico Bond <federicobond@gmail.com>
Signed-off-by: Federico Bond <federicobond@gmail.com>
Signed-off-by: Federico Bond <federicobond@gmail.com>
Signed-off-by: Federico Bond <federicobond@gmail.com>
d1cc64c
to
0425a15
Compare
This PR
Adds support for domains with a minimalist implementation. Feedback is especially welcome around public APIs and backward compatibility issues.
Builds on top of #270
Related Issues
Refs #125
Follow-up Tasks