fix: run error hooks if provider returns FlagResolutionDetails with non-empty error_code #291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #291 +/- ##
==========================================
+ Coverage 94.06% 94.19% +0.12%
==========================================
Files 18 18
Lines 539 551 +12
==========================================
+ Hits 507 519 +12
Misses 32 32
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
…on-empty error_code Signed-off-by: Federico Bond <federicobond@gmail.com>
federicobond
force-pushed
the
fix/error-hooks
branch
from
c1d5146
to
62b6301
Compare
gruebel
reviewed
Mar 11, 2024
Signed-off-by: Federico Bond <federicobond@gmail.com>
federicobond
force-pushed
the
fix/error-hooks
branch
from
351ec14
to
c0ae21e
Compare
gruebel
approved these changes
Mar 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.