Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove ProviderEvent.PROVIDER_FATAL #307

Merged

Conversation

federicobond
Copy link
Member

@federicobond federicobond commented Mar 28, 2024

PROVIDER_FATAL event does not exist. The FATAL status is reported through a PROVIDER_ERROR event.

See https://openfeature.dev/specification/types#provider-events

Signed-off-by: Federico Bond <federicobond@gmail.com>
Copy link

codecov bot commented Mar 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.77%. Comparing base (f00bc89) to head (de7bc7a).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #307      +/-   ##
==========================================
- Coverage   94.78%   94.77%   -0.01%     
==========================================
  Files          20       20              
  Lines         652      651       -1     
==========================================
- Hits          618      617       -1     
  Misses         34       34              
Flag Coverage Δ
unittests 94.77% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@federicobond federicobond merged commit de36b21 into open-feature:main Mar 28, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants