feat: implement transaction context #389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #389 +/- ##
==========================================
+ Coverage 97.41% 97.68% +0.26%
==========================================
Files 26 31 +5
Lines 1239 1382 +143
==========================================
+ Hits 1207 1350 +143
Misses 32 32
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
lukas-reining
force-pushed
the
feat/transaction-context
branch
2 times, most recently
from
025121a
to
4675572
Compare
Signed-off-by: Lukas Reining <lukas.reining@codecentric.de>
Signed-off-by: Lukas Reining <lukas.reining@codecentric.de>
Signed-off-by: Lukas Reining <lukas.reining@codecentric.de>
lukas-reining
force-pushed
the
feat/transaction-context
branch
from
4675572
to
67e4368
Compare
Signed-off-by: Lukas Reining <lukas.reining@codecentric.de>
lukas-reining
requested review from
federicobond,
beeme1mr,
ajhelsby,
toddbaert and
gruebel
Signed-off-by: Lukas Reining <lukas.reining@codecentric.de>
beeme1mr
approved these changes
Nov 18, 2024
gruebel
reviewed
Nov 19, 2024
openfeature/transaction_context/no_op_transaction_context_propagator.py
Outdated
Show resolved
Hide resolved
openfeature/transaction_context/transaction_context_propagator.py
Outdated
Show resolved
Hide resolved
…agator.py Co-authored-by: Anton Grübel <anton.gruebel@gmail.com> Signed-off-by: Lukas Reining <lukas.reining@codecentric.de>
lukas-reining
force-pushed
the
feat/transaction-context
branch
from
86620c2
to
1e93e32
Compare
Signed-off-by: Lukas Reining <lukas.reining@codecentric.de>
lukas-reining
force-pushed
the
feat/transaction-context
branch
from
1e93e32
to
bb0e8bc
Compare
gruebel
approved these changes
Nov 19, 2024
|
I'll give @federicobond till end of week to leave some comments, otherwise will merge this and close the previous draft. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements transaction context as described in #292.
This is done the same as in Node, the callback we have for Node is not needed with context vars, like it is in Java.
@federicobond just after I did the changes I saw you PR from May:
Sorry, I could have just continued test on this one.
We basically did the same but I added some tests also for the context merging.